Repository navigation
GH-40: Add MapVector usage example - #1475
yashdotdev13 wants to merge 1 commit into
Conversation
|
Hi maintainers, The PR is a documentation-only contribution. The required PR-format check is asking for a label. Could someone with repository permissions please apply the Thanks! |
This is not a test.
Were the docs built? Additionally, the original issue refers to the Cookbook, which is at https://github.com/apache/arrow-cookbook. |
|
Hi @lidavidm, Thanks for the feedback and for pointing me toward the Apache Arrow Cookbook! I've followed your suggestion and created a new PR in New PR: apache/arrow-cookbook#419 The new PR adds an Array of Map recipe to the Java Cookbook, demonstrating:
I have also completed the requested validation:
The Cookbook contribution is now submitted for review. Thanks again for the guidance! |
jbonofre
left a comment
There was a problem hiding this comment.
LGTM overall, having a Building MapVector section directly alongside Building ListVector in docs/source/vector.rst is useful and complements the apache/arrow-cookbook#419.
@lidavidm are you OK with landing this in arrow-java docs in addition to apache/arrow-cookbook#419?
|
Basically, I think this PR still makes sense in complement of the cookbook. |
|
Sure, the author never updated the PR description, though |
|
@lidavidm fair. @yashdotdev13 do you mind to update the description accordingly? Thanks! |
|
Hi @jbonofre, Thanks for the review and approval! Thanks for your feedback! |
Summary
Add a
MapVectorusage example to the Apache Arrow Java documentation.This contribution complements the Java Cookbook example in [apache/arrow-cookbook#419](apache/arrow-cookbook#419) by providing a corresponding example directly in the Arrow Java documentation.
The example demonstrates:
MapVector.UnionMapWriter.UnionMapReader.